This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING] [PATCH 01/14] S390: Get rid of make warning: overriding recipe for target gconv-modules.
- From: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Mon, 9 May 2016 16:15:17 +0200
- Subject: Re: [PING] [PATCH 01/14] S390: Get rid of make warning: overriding recipe for target gconv-modules.
- Authentication-results: sourceware.org; auth=none
- References: <1456219278-5258-1-git-send-email-stli at linux dot vnet dot ibm dot com> <1456219278-5258-2-git-send-email-stli at linux dot vnet dot ibm dot com> <570FA625 dot 3070303 at linux dot vnet dot ibm dot com> <nfaplc$1bi$12 at ger dot gmane dot org> <nfsbqo$ims$2 at ger dot gmane dot org> <ngcsl0$u8b$1 at ger dot gmane dot org> <mvmk2jakklf dot fsf at hawking dot suse dot de>
On 05/04/2016 03:40 PM, Andreas Schwab wrote:
Define a variable sysdep-gconv-modules that can be set by
sysdeps/.../Makefile, and use it in iconvdata/Makefile to cat the files
together. Please also fix the rule in sysdeps/s390/s390-64/Makefile to
use a temporary file to make the update atomic. Since we no longer
support empty objpfx the conditional test can be removed.
Andreas.
Okay. I will remove the objpfx conditional test in iconvdata/Makefile.
I have to add the s390 specific modules before all the other ones in
<source>/iconvdata/gconv-modules.
(See my second patch: "S390: Mention s390-specific gconv-modues before
common ones.")
Thus simply concatenating would lead to something like that:
"
# GNU libc iconv configuration.
# Copyright (C) 1997-2016 Free Software Foundation, Inc.
#....
s390-specific modules
# GNU libc iconv configuration.
# Copyright (C) 1997-2016 Free Software Foundation, Inc.
#....
common modules
"
This doesn't look very nice. Or is it okay?
Then I would prefer to create a file
<source>/sysdeps/s390/gconv-modules-s390 with the module-definitions,
set the variable sysdep-gconv-modules and omit the rule with "cp, echo,
echo ..." in sysdeps/s390/s390-64/Makefile at all.
Bye
Stefan