This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] localedef: check LC_IDENTIFICATION.category values
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Mike Frysinger <vapier at gentoo dot org>, libc-alpha at sourceware dot org
- Cc: keld at keldix dot com
- Date: Fri, 15 Apr 2016 00:44:00 -0400
- Subject: Re: [PATCH v2] localedef: check LC_IDENTIFICATION.category values
- Authentication-results: sourceware.org; auth=none
- References: <1460587532-5278-1-git-send-email-vapier at gentoo dot org> <1460668862-10196-1-git-send-email-vapier at gentoo dot org>
On 04/14/2016 05:21 PM, Mike Frysinger wrote:
> Currently localedef accepts any value for the category keyword. This has
> allowed bad values to propagate to the vast majority of locales (~90%).
> Add some logic to only accept a few standards.
>
> 2016-04-13 Mike Frysinger <vapier@gentoo.org>
>
> * locale/programs/ld-identification.c (identification_finish): Check
> that the values in identification->category are only known.
> ---
> v2:
> - tweak list of accepted standards
OK if you expand the comment "Only list the standards we care about." to
list the standards we reviewed when making this list, that way a future
developers can review.
--
Cheers,
Carlos.