This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] localedata: CLDRv29: update LC_ADDRESS.country_num values
- From: Andreas Schwab <schwab at suse dot de>
- To: Marko Myllynen <myllynen at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 12 Apr 2016 10:36:04 +0200
- Subject: Re: [PATCH v2] localedata: CLDRv29: update LC_ADDRESS.country_num values
- Authentication-results: sourceware.org; auth=none
- References: <1455939430-19704-1-git-send-email-vapier at gentoo dot org> <1460443470-14172-1-git-send-email-vapier at gentoo dot org> <mvmwpo3uut3 dot fsf at hawking dot suse dot de> <20160412075804 dot GS6588 at vapier dot lan> <mvmshyruua8 dot fsf at hawking dot suse dot de> <20160412081337 dot GT6588 at vapier dot lan> <mvmoa9futoo dot fsf at hawking dot suse dot de> <20160412082527 dot GV6588 at vapier dot lan> <mvmk2k3ut49 dot fsf at hawking dot suse dot de> <570CB29A dot 6070105 at redhat dot com>
Marko Myllynen <myllynen@redhat.com> writes:
> Hi,
>
> On 2016-04-12 11:30, Andreas Schwab wrote:
>> Mike Frysinger <vapier@gentoo.org> writes:
>>> On 12 Apr 2016 10:17, Andreas Schwab wrote:
>>>> Mike Frysinger <vapier@gentoo.org> writes:
>>>>> On 12 Apr 2016 10:05, Andreas Schwab wrote:
>>>>>> Mike Frysinger <vapier@gentoo.org> writes:
>>>>>>> On 12 Apr 2016 09:53, Andreas Schwab wrote:
>>>>>>>> Mike Frysinger <vapier@gentoo.org> writes:
>>>>>>>>> --- a/localedata/locales/ca_AD
>>>>>>>>> +++ b/localedata/locales/ca_AD
>>>>>>>>> @@ -96,7 +96,7 @@ postal_fmt "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/
>>>>>>>>> <U004E><U0025><U0063><U0025><U004E>"
>>>>>>>>> country_ab2 "<U0041><U0044>"
>>>>>>>>> country_ab3 "<U0041><U004E><U0044>"
>>>>>>>>> -country_num 20
>>>>>>>>> +country_num 020
>>>>>>>>
>>>>>>>> This is a plain number so the leading zero is not significant.
>>>>>>>
>>>>>>> i documented this in the commit message
>>>>>>
>>>>>> That doesn't make it correct.
>>>>>
>>>>> nor does it make it incorrect. i've provided justification for the
>>>>> change at this point.
>>>>
>>>> "Add leading 0 prefix" is not justification.
>>>
>>> like i already said, read the *commit message*.
>>
>> I did. No justification.
>
> Please reread it, there was justification.
"Other sources doing it wrong, too" is not a justification.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."