This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] strfmon_l: Use specified locale for number formatting [BZ #19633]


@Andreas:
Just to be sure. Is this second patch okay? Then I`ll commit it.

Bye Stefan

On 04/05/2016 05:05 PM, Stefan Liebler wrote:
On 04/05/2016 02:50 PM, Andreas Schwab wrote:
Stefan Liebler <stli@linux.vnet.ibm.com> writes:

diff --git a/stdio-common/printf_fp.c b/stdio-common/printf_fp.c
index baada9e..fb2a763 100644
--- a/stdio-common/printf_fp.c
+++ b/stdio-common/printf_fp.c
@@ -1248,8 +1248,8 @@ ___printf_fp_l (FILE *fp, locale_t loc,
    }
    return done;
  }
-ldbl_hidden_def (___printf_fp_l, __printf_fp_l)
-ldbl_strong_alias (___printf_fp_l, __printf_fp_l)
+libc_hidden_def (__printf_fp_l)
+strong_alias (___printf_fp_l, __printf_fp_l)

Please rename ___printf_fp_l to __printf_fp_l, no need for the alias.
Otherwise looks ok.

Andreas.

Here is an updated patch to reflect the mentioned changes.
Okay to commit?

ChangeLog:

2016-04-05  Stefan Liebler  <stli@linux.vnet.ibm.com>

     * stdio-common/printf_fp.c (__printf_fp_l):
     Rename ___printf_fp_l to __printf_fp_l and
     remove strong alias. Use libc_hidden_def instead
     of ldbl_hidden_def macro.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]