This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix building glibc master with NDEBUG.
- From: Florian Weimer <fweimer at redhat dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 11 Mar 2016 09:44:31 +0100
- Subject: Re: [PATCH] Fix building glibc master with NDEBUG.
- Authentication-results: sourceware.org; auth=none
- References: <56E22D8E dot 8050500 at redhat dot com>
On 03/11/2016 03:29 AM, Carlos O'Donell wrote:
> * catgets/tst-catgets.c (do_bz17905): Mark result unused.
> * dlfcn/bug-dl-leaf-lib.c (check_val_fini): Mark ret unused.
> * math/atest-exp.c (exp_mpn): Mark chk unused.
> * math/atest-exp2.c (exp_mpn): Likwise.
Tests should not use assert because it writes the message to standard
error, not standard output, where it is captured. We can add a
different macro to test-skeleton.c for this purpose. It would be useful
in many cases.
> * sysdeps/arm/dl-machine.h (elf_machine_rela): Mark td unused.
This seems okay.
> * sysdeps/i386/i686/dl-hash.h: Mark _dl_elf_hash unused.
This one is not related to NDEBUG, I think, but to --with-cpu.
Florian