This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] getnameinfo: Do not restore errno on error
- From: Florian Weimer <fweimer at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 8 Mar 2016 16:20:42 +0100
- Subject: Re: [PATCH] getnameinfo: Do not restore errno on error
- Authentication-results: sourceware.org; auth=none
- References: <56DEE16A dot 5010305 at redhat dot com> <CAKCAbMjp_gRyQqDPiDrj=P0xqSv_wqO7weBPWMCdJnrPh9xt-w at mail dot gmail dot com>
On 03/08/2016 04:14 PM, Zack Weinberg wrote:
> On Tue, Mar 8, 2016 at 9:27 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> POSIX does not require it, and this behavior is not documented
>> in the manual page, either.
>
> This might be OK in the actual error case, but you're stomping on
> errno in the *non*-error case too, which, even if allowed, should be
> avoided as a matter of QoI.
We currently do not have this as a general goal for glibc functions. I
don't think getnameinfois special so that an exception is warranted (
(unlike, say, free).
Florian