This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix min/max needed for ascii to INTERNAL conversion
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 8 Mar 2016 10:36:21 +0100
- Subject: Re: [PATCH] Fix min/max needed for ascii to INTERNAL conversion
- Authentication-results: sourceware.org; auth=none
- References: <mvmsi02utc4 dot fsf at hawking dot suse dot de> <56DDF0A0 dot 9040308 at redhat dot com> <mvmk2lduy1t dot fsf at hawking dot suse dot de>
On 03/08/2016 10:19 AM, Andreas Schwab wrote:
> Florian Weimer <fweimer@redhat.com> writes:
>
>> On 03/07/2016 05:48 PM, Andreas Schwab wrote:
>>> The values are swapped. Installed as obvious.
>>>
>>> Andreas.
>>>
>>> * iconv/gconv_builtin.h ("=ascii->INTERNAL"): Correct min/max
>>> needed arguments.
>>
>> What's the impact? Is it possible to write a test that shows a difference?
>
> It's not a correctness issue, just efficiency. The max_needed_to value
> is used in gconv_open to size the internal buffer between two steps, and
> the min_needed_from value has no real relevance (when
> __gconv_transform_ascii_internal returns __GCONV_EMPTY_INPUT, it has
> already consumed all of the input buffer anyway). The other two values
> are never used.
Thank you for your detailed explanation. It answers my question.
Florian