This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix min/max needed for ascii to INTERNAL conversion


On 03/08/2016 10:19 AM, Andreas Schwab wrote:
> Florian Weimer <fweimer@redhat.com> writes:
> 
>> On 03/07/2016 05:48 PM, Andreas Schwab wrote:
>>> The values are swapped.  Installed as obvious.
>>>
>>> Andreas.
>>>
>>> 	* iconv/gconv_builtin.h ("=ascii->INTERNAL"): Correct min/max
>>> 	needed arguments.
>>
>> What's the impact?  Is it possible to write a test that shows a difference?
> 
> It's not a correctness issue, just efficiency.  The max_needed_to value
> is used in gconv_open to size the internal buffer between two steps, and
> the min_needed_from value has no real relevance (when
> __gconv_transform_ascii_internal returns __GCONV_EMPTY_INPUT, it has
> already consumed all of the input buffer anyway).  The other two values
> are never used.

Thank you for your detailed explanation.  It answers my question.

Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]