This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 2/2] Use direct socket syscalls for new kernels on sparc

From: "Dmitry V. Levin" <ldv at altlinux dot org>
To: Aurelien Jarno <aurelien at aurel32 dot net>
Cc: libc-alpha at sourceware dot org, "David S . Miller" <davem at davemloft dot net>
Date: Fri, 4 Mar 2016 21:25:57 +0300
Subject: Re: [PATCH v3 2/2] Use direct socket syscalls for new kernels on sparc
Authentication-results: sourceware.org; auth=none
References: <1457113849-16532-1-git-send-email-aurelien at aurel32 dot net> <1457113849-16532-3-git-send-email-aurelien at aurel32 dot net>

On Fri, Mar 04, 2016 at 06:50:49PM +0100, Aurelien Jarno wrote:
> All direct socket syscalls have been added in kernel version 4.4 for
> SPARC32.
> 
> The 3 missing direct socket syscalls bind, listen and setsockopt have
> been added in kernel version 4.4 for SPARC64. All others were already
> present for SPARC64 in kernel versions 3.2 or earlier.
> 
> Changelog:
> 	* sysdeps/unix/sysv/linux/sparc/kernel-features.h
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_ACCEPT_SYSCALL): New macro.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_CONNECT_SYSCALL): Likewise.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_GETPEERNAME_SYSCALL): Likewise.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_GETSOCKNAME_SYSCALL): Likewise.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_GETSOCKOPT_SYSCALL): Likewise.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_RECV_SYSCALL): Likewise.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_RECVFROM_SYSCALL): Likewise.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_RECVMSG_SYSCALL): Likewise.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_SENDMSG_SYSCALL): Likewise.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_SENDTO_SYSCALL): Likewise.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_SENDTO_FOR_SEND_SYSCALL): Likewise.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_SHUTDOWN_SYSCALL): Likewise.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_SOCKET_SYSCALL): Likewise.
> 	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
> 	(ASSUME_SOCKETPAIR_SYSCALL): Likewise.
> 	[__LINUX_KERNEL_VERSION >= 0x040400] (__ASSUME_BIND_SYSCALL):
> 	Likewise.
> 	[__LINUX_KERNEL_VERSION >= 0x040400] (__ASSUME_LISTEN_SYSCALL):
> 	Likewise.
> 	[__LINUX_KERNEL_VERSION >= 0x040400] (__ASSUME_SETSOCKOPT_SYSCALL):
> 	Likewise.

I suggest to make the ChangeLog entry for this change more compact, e.g.

	* sysdeps/unix/sysv/linux/sparc/kernel-features.h
	[ __arch64__ || __LINUX_KERNEL_VERSION >= 0x040400]
	(__ASSUME_ACCEPT_SYSCALL, __ASSUME_CONNECT_SYSCALL,
	__ASSUME_GETPEERNAME_SYSCALL, __ASSUME_GETSOCKNAME_SYSCALL,
	__ASSUME_GETSOCKOPT_SYSCALL, __ASSUME_RECV_SYSCALL,
	__ASSUME_RECVFROM_SYSCALL, __ASSUME_RECVMSG_SYSCALL,
	__ASSUME_SENDMSG_SYSCALL, __ASSUME_SENDTO_SYSCALL,
	__ASSUME_SENDTO_FOR_SEND_SYSCALL, __ASSUME_SHUTDOWN_SYSCALL,
	__ASSUME_SOCKET_SYSCALL, __ASSUME_SOCKETPAIR_SYSCALL):
	New macros.
	[__LINUX_KERNEL_VERSION >= 0x040400] (__ASSUME_BIND_SYSCALL,
	__ASSUME_LISTEN_SYSCALL, __ASSUME_SETSOCKOPT_SYSCALL): Likewise.

-- 
ldv

Attachment: pgp6Ff8r2lPZP.pgp
Description: PGP signature

Follow-Ups:
- Re: [PATCH v3 2/2] Use direct socket syscalls for new kernels on sparc
  - From: Aurelien Jarno

References:
- [PATCH v3 0/2] sparc64: fix socket syscalls with recent kernel headers
  - From: Aurelien Jarno
- [PATCH v3 2/2] Use direct socket syscalls for new kernels on sparc
  - From: Aurelien Jarno

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]