This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] BZ #19590: Fixed build of shared objects that use libmvec.so functions
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Tue, 16 Feb 2016 06:23:34 -0800
- Subject: Re: [PATCH] BZ #19590: Fixed build of shared objects that use libmvec.so functions
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3tML81iuKQMKRU-T4Fw0+=sYk0q_BNavMGagt21VcYvzQ at mail dot gmail dot com> <CAMe9rOp7BF2avdWbGTbsxuYQV_rmXSxzDUAwz+nHK-GhWqPKJA at mail dot gmail dot com> <CAMXFM3sG90jn3Em-REfaqtj3OGAjh51OcO=yn1qHqJ4aStkPrg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602111641250 dot 29940 at digraph dot polyomino dot org dot uk> <CAMXFM3uxH=0DHnwikPjs2AobQ0kxOqKg+j=CuOWX=RLB_i8hxg at mail dot gmail dot com> <CAMe9rOoWy+hqiCOKqFx0nOFVRT_kBETJ5hYE+cY6pFWUke=tkw at mail dot gmail dot com> <CAMXFM3vG1DNELfGaOOoUvRDGgrGWL4m3M8+5ngPg8RPnCLqUog at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602161347240 dot 26462 at digraph dot polyomino dot org dot uk>
On Tue, Feb 16, 2016 at 5:49 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Tue, 16 Feb 2016, Andrew Senkevich wrote:
>
>> Here is patch with tests.
>
> This is the wrong approach for tests. Tests for this should not be
> testing implementation details about aliases, and so should not be
> creating any wrappers at all. They should be testing vectorizable calls
> to the scalar functions, compiled several times with different options
> into both executables and shared libraries.
>
Andrew, please update BZ 19590 with a real GCC testcase to show
the problem.
You can need [BZ #19590] in ChangeLog.
--
H.J.