This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] BZ #19590: Fixed build of shared objects that use libmvec.so functions
- From: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 11 Feb 2016 16:50:24 +0300
- Subject: Re: [PATCH] BZ #19590: Fixed build of shared objects that use libmvec.so functions
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3tML81iuKQMKRU-T4Fw0+=sYk0q_BNavMGagt21VcYvzQ at mail dot gmail dot com> <CAMe9rOp7BF2avdWbGTbsxuYQV_rmXSxzDUAwz+nHK-GhWqPKJA at mail dot gmail dot com>
2016-02-10 15:45 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
> On Wed, Feb 10, 2016 at 3:36 AM, Andrew Senkevich
> <andrew.n.senkevich@gmail.com> wrote:
>> Hi,
>>
>> here the fix for BZ #19590.
>>
>>
>> diff --git a/ChangeLog b/ChangeLog
>> index 11c3156..6ebcefb 100644
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1,3 +1,9 @@
>> +2016-02-10 Andrew Senkevich <andrew.senkevich@intel.com>
>> + Carlos O'Donell <carlos@redhat.com>
>> +
>> + [BZ #19590]
>> + * sysdeps/x86_64/fpu/svml_finite_alias.S (ALIAS_IMPL): Use PLT.
>> +
>> 2016-02-04 Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
>>
>> * sysdeps/powerpc/fpu/libm-test-ulps: Regenerated.
>> diff --git a/sysdeps/x86_64/fpu/svml_finite_alias.S
>> b/sysdeps/x86_64/fpu/svml_finite_alias.S
>> index 0062fe4..0da3b64 100644
>> --- a/sysdeps/x86_64/fpu/svml_finite_alias.S
>> +++ b/sysdeps/x86_64/fpu/svml_finite_alias.S
>> @@ -23,7 +23,7 @@
>>
>> #define ALIAS_IMPL(alias, target) \
>> ENTRY (alias); \
>> - call target; \
>> + call target@PLT; \
>> ret; \
>> END (alias)
>>
>>
>
> Need a testcase, You can use assembly code in testcase to make it
> compiler independent.
If we need runtime tests with calls to finite aliases it looks better
to adopt build of existing libmvec tests. We can call finite aliases
in *-wrappers.c and build shared library from them and link with it
test binaries. Is this approach looks OK?
--
WBR,
Andrew