This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH COMMITTED] Adjust sparc 32-bit __sqrtl_finite version tag.
- From: David Miller <davem at davemloft dot net>
- To: joseph at codesourcery dot com
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 25 Jan 2016 11:00:50 -0800 (PST)
- Subject: Re: [PATCH COMMITTED] Adjust sparc 32-bit __sqrtl_finite version tag.
- Authentication-results: sourceware.org; auth=none
- References: <20160125 dot 104334 dot 434410107130817436 dot davem at davemloft dot net> <alpine dot DEB dot 2 dot 10 dot 1601251846010 dot 10557 at digraph dot polyomino dot org dot uk>
From: Joseph Myers <joseph@codesourcery.com>
Date: Mon, 25 Jan 2016 18:47:21 +0000
> Presumably you also need to add a Versions entry for this and maybe define
> the function using versioned_symbol, so that it gets exported at the new
> version and does not get exported at the old version?
Hmmm, something like this?
diff --git a/sysdeps/sparc/sparc32/fpu/e_sqrtl.c b/sysdeps/sparc/sparc32/fpu/e_sqrtl.c
index 46ad861..30d4d34 100644
--- a/sysdeps/sparc/sparc32/fpu/e_sqrtl.c
+++ b/sysdeps/sparc/sparc32/fpu/e_sqrtl.c
@@ -26,3 +26,6 @@ __ieee754_sqrtl (long double x)
return _Q_sqrt (x);
}
strong_alias (__ieee754_sqrtl, __sqrtl_finite)
+
+#include <shlib-compat.h>
+versioned_symbol (libm, __sqrtl_finite, sqrtl_finite, GLIBC_2_23);
diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/Versions b/sysdeps/unix/sysv/linux/sparc/sparc32/Versions
index c9a5b3e..a0b9c19 100644
--- a/sysdeps/unix/sysv/linux/sparc/sparc32/Versions
+++ b/sysdeps/unix/sysv/linux/sparc/sparc32/Versions
@@ -24,3 +24,9 @@ libc {
fallocate64;
}
}
+
+libm {
+ GLIBC_2.23 {
+ __sqrtl_finite;
+ }
+}