This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] tst-malloc-thread-exit: run less aggressively


On 01/23/2016 03:59 AM, Chris Metcalf wrote:
> On 1/22/2016 2:00 PM, Florian Weimer wrote:
>> On 01/22/2016 06:34 PM, Florian Weimer wrote:
>>> I haven't finished the mallopt approach.  It seems that my mental model
>>> how the test works is wrong.  Two threads with eight arenas appear to
>>> trigger the issue reliably, but I want to test on a larger machine as
>>> well, to make sure the test is any good there.  The problem there is
>>> that I wasn't
>> … able to find sufficiently large box.  That has now changed, and I can
>> confirm that the bug still reproduces with the changed test.
>>
>> Chris, can you confirm that the tweaked test addresses your problem?
>> Then I'll send a real patch for review.
> 
> Yes, with your patch the test passes, in just over 5 seconds of runtime.

Did you try this patch with the fix backed out?  Does it still fail?

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]