This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix #19444 - build failures with -O1 due to -Wmaybe-uninitialized


On Thu, 14 Jan 2016, H.J. Lu wrote:

> This is the right direction, but may not work with -Os.  I am working
> on a patch to add bits/string-1.h to define _STRING_ARCH_unaligned,
> which is included unconditionally.

Suppose you apply all Wilco's patches related to string inlines (including 
those that remove many of them from bits/string2.h).  Are there any 
remaining references to _STRING_ARCH_unaligned in installed headers other 
than the definition?

If so, what are they?  If not, it should be moved out of installed headers 
as I said (and bits/ is a namespace exclusively for installed headers).  
Installed headers should not define things only relevant for building 
glibc, or contain _LIBC conditionals, except where we don't have a cleaner 
alternative for how to avoid internals creeping into installed headers.  
The first preference should be that internal things go in internal headers 
(which includes the include/ wrappers, though arguably those should be 
slimmed down as well with more internal interfaces going in separate 
internal headers that are explicitly included, not in a header with the 
same name as one that gets installed).

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]