This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] nptl: support thread stacks that grow up [ping]

From: Mike Frysinger <vapier at gentoo dot org>
To: Roland McGrath <roland at hack dot frob dot com>
Cc: libc-alpha at sourceware dot org
Date: Tue, 12 Jan 2016 17:00:22 -0500
Subject: Re: [PATCH] nptl: support thread stacks that grow up [ping]
Authentication-results: sourceware.org; auth=none
References: <1439108237-31537-1-git-send-email-vapier at gentoo dot org> <20151229225736 dot GN25803 at vapier dot lan> <20160109083231 dot GA28268 at vapier dot lan> <20160112210341 dot BB09F2C3C2F at topped-with-meat dot com>

On 12 Jan 2016 13:03, Roland McGrath wrote:
> It looks OK to me.  If you can verify that it doesn't change the generated
> code nontrivially on x86_64, then I think that is sufficient to declare it
> safe enough for working machines.  And grows-up machines are sufficiently
> broken today in trunk that I'm not concerned about you making them worse.

pthread_create.c & pthread_getattr_np.c have mostly the same disassembly.
my gcc is being weird and changing a constant in one insn depending on
whitespace in the file.

allocatestack.c has some code shuffling, but it's the same size overall.

tests still pass on x86_64.

i'll push after the 2.23 branch.
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] nptl: support thread stacks that grow up [ping]
  - From: Carlos O'Donell

References:
- Re: [PATCH] nptl: support thread stacks that grow up [ping]
  - From: Mike Frysinger
- Re: [PATCH] nptl: support thread stacks that grow up [ping]
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]