This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Add framework for tunables
- From: Siddhesh Poyarekar <sid at reserved-bit dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org, roland at hack dot frob dot com, carlos at redhat dot com, "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>, Andi Kleen <andi at firstfloor dot org>
- Date: Tue, 12 Jan 2016 07:47:50 +0530
- Subject: Re: [PATCH 1/2] Add framework for tunables
- Authentication-results: sourceware.org; auth=none
- References: <20160111111649 dot GA4157 at devel dot intra dot reserved-bit dot com> <alpine dot DEB dot 2 dot 10 dot 1601111901520 dot 23402 at digraph dot polyomino dot org dot uk>
On Mon, Jan 11, 2016 at 07:02:46PM +0000, Joseph Myers wrote:
> On Mon, 11 Jan 2016, Siddhesh Poyarekar wrote:
>
> > +# * False positive: tunable_register, compat_tunables_init_envvars,
> > +# tunables_init. These functions are in the glibc internal namespace.
> > @whitelist = qw(stdin stdout stderr re_syntax_options matherr matherrf
> > - matherrl);
> > + matherrl tunable_register compat_tunables_init_envvars tunables_init);
>
> I don't understand this comment. None of those names are in an internal
> namespace. All those functions should be renamed to start with __.
Oh, I meant that they're in the GLIBC_PRIVATE namespace. In any case,
I'll remove these aliases and make libc_hidden_def instead to get
__GI___* for internal use.
Thanks,
Siddhesh