This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv5] - powerpc: Add hwcap/hwcap2/platform data to TCB.
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Carlos Eduardo Seo <cseo at linux dot vnet dot ibm dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Cc: "Carlos O'Donell" <carlos at redhat dot com>, Tulio Machado <tuliom at linux dot vnet dot ibm dot com>, "Steven J. Munroe" <sjmunroe at us dot ibm dot com>
- Date: Mon, 26 Oct 2015 16:31:05 -0500
- Subject: Re: [PATCHv5] - powerpc: Add hwcap/hwcap2/platform data to TCB.
- Authentication-results: sourceware.org; auth=none
- References: <462274D6-C7A4-4186-8B73-65BE70336DE6 at linux dot vnet dot ibm dot com>
On Fri, 2015-10-23 at 14:15 -0200, Carlos Eduardo Seo wrote:
+ if (h1 & PPC_FEATURE_ARCH_2_06)
+ h1 |= PPC_FEATURE_ARCH_2_05 | \
+ PPC_FEATURE_POWER5_PLUS | \
+ PPC_FEATURE_POWER5 | \
+ PPC_FEATURE_POWER4;
+ else if (h1 & PPC_FEATURE_ARCH_2_05)
+ h1 |= PPC_FEATURE_POWER5_PLUS | \
+ PPC_FEATURE_POWER5 | \
+ PPC_FEATURE_POWER4;
+ else if (h1 & PPC_FEATURE_POWER5_PLUS)
+ h1 |= PPC_FEATURE_POWER5 | \
+ PPC_FEATURE_POWER4;
+ else if (h1 & PPC_FEATURE_POWER5)
+ h1|= PPC_FEATURE_POWER4;C
I just realized this isn't complete. You're not testing for
PPC_FEATURE_ARCH_2_07 which is stored in hwcap2/h2. So I guess
this should look like:
if (h2 & PPC_FEATURE_ARCH_2_07)
h1 |= PPC_FEATURE_ARCH_2_06
| PPC_FEATURE_ARCH_2_05
| PPC_FEATURE_POWER5_PLUS
| PPC_FEATURE_POWER5
| PPC_FEATURE_POWER4;
else if (h1 & PPC_FEATURE_ARCH_2_06)
h1 |= PPC_FEATURE_ARCH_2_05
| PPC_FEATURE_POWER5_PLUS
| PPC_FEATURE_POWER5
| PPC_FEATURE_POWER4;
else if (h1 & PPC_FEATURE_ARCH_2_05)
h1 |= PPC_FEATURE_POWER5_PLUS
| PPC_FEATURE_POWER5
| PPC_FEATURE_POWER4;
else if (h1 & PPC_FEATURE_POWER5_PLUS)
h1 |= PPC_FEATURE_POWER5
| PPC_FEATURE_POWER4;
else if (h1 & PPC_FEATURE_POWER5)
h1 |= PPC_FEATURE_POWER4;
Peter