This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Convert 703 function definitions to prototype style
- From: Florian Weimer <fweimer at redhat dot com>
- To: joseph at codesourcery dot com
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 16 Oct 2015 20:45:54 +0200
- Subject: Re: Convert 703 function definitions to prototype style
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1510161815490 dot 26375 at digraph dot polyomino dot org dot uk>
On 10/16/2015 08:17 PM, Joseph Myers wrote:
> Tested for x86_64 and x86 (testsuite, and that installed stripped
> shared libraries are unchanged by the patch).
I reviewed a few random :) parts of the patch. They seemed reasonable.
So let's do it. If there is any fallout from this, we can hopefully
distill new test cases from the failures.
I'm surprised you didn't have to add any internal_function annotations.
I read somewhere that GCC wouldn't complain about mismatches if an
old-style function definition is missing them.
Florian