This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3] Add LFS support for fts functions [BZ #11460]

From: "Dmitry V. Levin" <ldv at altlinux dot org>
To: Mark Wielaard <mjw at redhat dot com>
Cc: libc-alpha at sourceware dot org, Andreas Schwab <schwab at suse dot de>, Joseph Myers <joseph at codesourcery dot com>
Date: Wed, 14 Oct 2015 20:15:48 +0300
Subject: Re: [PATCH v3] Add LFS support for fts functions [BZ #11460]
Authentication-results: sourceware.org; auth=none
References: <1444774958-30837-1-git-send-email-mjw at redhat dot com>

On Wed, Oct 14, 2015 at 12:22:38AM +0200, Mark Wielaard wrote:
> changes:
> - Remove redundant initialization in test.
> - Use %m instead of %s with strerror(errno) in test.
> - Use 0600/0700 modes for open/mkdir in test.
> - Replace error with printf/exit(1) in test.
> - Use asprintf instead of malloc+snprintf in test.

LGTM, thanks.


-- 
ldv

Attachment: pgpvBqYamFH45.pgp
Description: PGP signature

References:
- [PATCH v3] Add LFS support for fts functions [BZ #11460]
  - From: Mark Wielaard

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]