This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 6/6] i386: Remove syscall assembly codes with 6 arguments
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 14 Oct 2015 12:56:44 -0400
- Subject: Re: [PATCH 6/6] i386: Remove syscall assembly codes with 6 arguments
- Authentication-results: sourceware.org; auth=none
- References: <20151012232041 dot GD8797 at intel dot com> <CAMe9rOq=z5ta3-K7Ljc17bbJ4B0gp50BWP34PKT0dCfZNn0h-w at mail dot gmail dot com>
On 10/14/2015 08:54 AM, H.J. Lu wrote:
>> * sysdeps/unix/sysv/linux/i386/Makefile (CFLAGS-epoll_pwait.c):
>> Add -fomit-frame-pointer.
>> (CFLAGS-mmap.c): Likewise.
>> (CFLAGS-mmap64.c): Likewise.
>> (CFLAGS-semtimedop.c): Likewise.
>> * sysdeps/unix/sysv/linux/i386/mmap.c: New file.
>> * sysdeps/unix/sysv/linux/i386/epoll_pwait.S: Remove file.
>> * sysdeps/unix/sysv/linux/i386/mmap.S: Likewise.
>> * sysdeps/unix/sysv/linux/i386/mmap64.S: Likewise.
>> * sysdeps/unix/sysv/linux/i386/semtimedop.S: Likewise.
>
> 3 of 6 patches have been checked in. Here is the updated patch.
> OK for master?
How did you test this? OK if you did some real network testing
with this glibc, because nothing tests epoll_pwait in the testsuite.
AFAICT we are falling back to sysdeps/unix/sysv/linux/mmap64.c,
and that's OK. Likewise for epoll_pwait and semtimedop.s.
Verified args, particularly IPCOP_semtimedop match the kernel
definition, and that the resulting INLINE_SYSCALL looks sane.
This looks good to me, and the fallbacks look good too.
OK as long as you tested epoll_pwait.
Cheers,
Carlos.