This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/6] Use INTERNAL_SYSCALL and INLINE_SYSCALL_ERROR_RETURN
- From: Andreas Schwab <schwab at suse dot de>
- To: "H.J. Lu" <hongjiu dot lu at intel dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Tue, 13 Oct 2015 09:37:48 +0200
- Subject: Re: [PATCH 4/6] Use INTERNAL_SYSCALL and INLINE_SYSCALL_ERROR_RETURN
- Authentication-results: sourceware.org; auth=none
- References: <20151012232011 dot GB8797 at intel dot com>
"H.J. Lu" <hongjiu.lu@intel.com> writes:
> + INTERNAL_SYSCALL_DECL (err);
> + result = INTERNAL_SYSCALL (fstat64, err, 2, fd, &buf64);
> + if (__glibc_unlikely (INTERNAL_SYSCALL_ERROR_P (result, )))
Either use err in both macro calls, or omit it in both. Our API calls
for the use of it, so I prefer the former.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."