This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: make check build failure (tst-printf-bz18872)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <sellcey at imgtec dot com>, <libc-alpha at sourceware dot org>
- Date: Thu, 8 Oct 2015 22:19:45 +0000
- Subject: Re: make check build failure (tst-printf-bz18872)
- Authentication-results: sourceware.org; auth=none
- References: <1444338226 dot 8687 dot 307 dot camel at ubuntu-sellcey> <20151008210634 dot 4BA352C3ABF at topped-with-meat dot com> <1444339336 dot 8687 dot 311 dot camel at ubuntu-sellcey> <20151008213221 dot CFDB32C3AA0 at topped-with-meat dot com> <1444340553 dot 8687 dot 319 dot camel at ubuntu-sellcey> <20151008215558 dot C91542C3AA0 at topped-with-meat dot com> <alpine dot DEB dot 2 dot 10 dot 1510082214450 dot 8465 at digraph dot polyomino dot org dot uk> <20151008221755 dot C91042C3ABF at topped-with-meat dot com>
On Thu, 8 Oct 2015, Roland McGrath wrote:
> > > 2015-10-08 Roland McGrath <roland@hack.frob.com>
> > >
> > > [BZ #18872]
> > > * stdio-common/Makefile ($(objpfx)tst-unbputc.out):
> > > Move out from under [$(run-built-tests) = yes] conditional.
> >
> > That looks wrong. tst-unbputc.sh uses test_program_prefix to run a newly
> > built test.
>
> Oh, it was unrelated. I failed to notice that. But why is it wrong? I
> don't see why we need to avoid defining the targets. Adding them to
> tests-special is conditionalized, so nothing will depend on that.
In that case it should be OK (but maybe we should be consistent, in
whatever direction, about when such rules are / aren't conditionalized).
--
Joseph S. Myers
joseph@codesourcery.com