This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix memory leak in printf_positional
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: "Carlos O'Donell" <carlos at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>, Paul Eggert <eggert at cs dot ucla dot edu>, GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Thu, 3 Sep 2015 08:59:25 -0700
- Subject: Re: [PATCH] Fix memory leak in printf_positional
- Authentication-results: sourceware.org; auth=none
- References: <1440571295-20230-1-git-send-email-eggert at cs dot ucla dot edu> <alpine dot DEB dot 2 dot 10 dot 1508260930500 dot 26898 at digraph dot polyomino dot org dot uk> <55DFB7C7 dot 50307 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1508281350520 dot 5939 at digraph dot polyomino dot org dot uk> <55E06924 dot 2000209 at redhat dot com> <CALoOobMkGafD9zvq9g13TM8_Nd+HmC58_8gMGTQhdefXpko3CA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1508311039110 dot 27932 at digraph dot polyomino dot org dot uk> <CALoOobO2iV9hPNB_S7PDoL=cWVCPrSkKGaUQfqboxUg40fsrVw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1509021004030 dot 3590 at digraph dot polyomino dot org dot uk> <CALoOobN6LcGFEkieN3CJQ7mKeL7m5H3_aaYb17uEW9ZE_zX4yA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1509021427530 dot 27392 at digraph dot polyomino dot org dot uk> <55E73436 dot 1050305 at redhat dot com> <CALoOobMusa6usQCEAR2bs8ES2EbHRa9YuCARd9=ewq1eROPLmQ at mail dot gmail dot com> <mvmvbbsrmo4 dot fsf at hawking dot suse dot de> <CALoOobN0wsGZNMkg355rpoEiDjy66B=Up0WHf35BPgGcPMxuhA at mail dot gmail dot com> <mvm37yvsh34 dot fsf at hawking dot suse dot de> <CALoOobPeFxJUreNJD61+tvka3MfBcZF6zsEerWcKCJW5H8J63A at mail dot gmail dot com>
On Thu, Sep 3, 2015 at 7:44 AM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> On Thu, Sep 3, 2015 at 7:38 AM, Andreas Schwab <schwab@suse.de> wrote:
>
>>> Sorry, I didn't understand that comment.
>>
>> The target must always be either complete or absent. A redirection is
>> not atomic.
Revised patch addressing all comments attached.
Thanks,
2015-09-03 Paul Eggert <eggert@cs.ucla.edu>
Paul Pluzhnikov <ppluzhnikov@google.com>
[BZ #18872]
* stdio-common/Makefile (tst-printf-bz18872): New test.
(tst-printf-bz18872-mem.out): Likewise.
* stdio-common/tst-printf-bz18872.sh: Generate new test.
* stdio-common/vfprintf.c: Fix memory leaks.
--
Paul Pluzhnikov
Attachment:
bz18872.20150903.txt
Description: Text document