This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix broken overflow check in posix_fallocate


Florian Weimer wrote:
That part I had seen before, but I also expected something like this:

+	Fix broken overflow check in posix_fallocate
+	* sysdeps/posix/posix_fallocate.c (posix_fallocate):
+	Fix parenthesization typo.
+	* sysdeps/posix/posix_fallocate64.c (__posix_fallocate64_l64):
+	Likewise.

Nowadays the "Likewise" style is considered old-fashioned in the other projects I hang out in. Although it's fine and is still used on occasion, it feels a bit like writing "whereas" or "henceforth". I don't know whether the newer style has been formally documented anywhere, but it's quite common and it is terser.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]