This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]


On Wed, 19 Aug 2015, H.J. Lu wrote:

> I will check in this on Friday unless there is an objection.

What's the evidence of consensus for the patch you checked in?  It's not 
clear that anyone reviewed the substance of it at all.

Problems I note in the committed patch include:

-    return INLINE_SYSCALL (lstat, 2, name, (struct kernel_stat *) buf);
+    return INLINE_SYSCALL_ERROR_RETURN (lstat, 2, int, name,
+                                       (struct kernel_stat *) buf);

where you're calling the wrong macro (should be INLINE_SYSCALL_RETURN), 
and the apparently arbitrary insertion of libc_hidden_* calls in 
sysdeps/unix/sysv/linux/sched_getaffinity.c, which ought to be in a 
separate patch.

At this point I think this commit should be reverted as lacking consensus.  
Then a suitably cleaned up version needs to be reviewed properly before 
going in.  Silence does not generally mean consensus (we discussed such an 
idea for unmaintained architectures, but x86 is not an unmaintained 
architecture, it's maintained by community review).

I suspect the patch would also better be split up into the most mechanical 
changes that don't change generated code at all, and the less obvious 
pieces needing more careful review.

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]