This is the mail archive of the
mailing list for the glibc project.
Re: Don't use -Wno-error=undef
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 19 Aug 2015 00:56:56 +0000
- Subject: Re: Don't use -Wno-error=undef
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1508181621220 dot 17603 at digraph dot polyomino dot org dot uk> <20150818172337 dot GO1584 at vapier> <alpine dot DEB dot 2 dot 10 dot 1508181725240 dot 17603 at digraph dot polyomino dot org dot uk> <20150818235331 dot GP1584 at vapier>
On Tue, 18 Aug 2015, Mike Frysinger wrote:
> On 18 Aug 2015 17:27, Joseph Myers wrote:
> > On Tue, 18 Aug 2015, Mike Frysinger wrote:
> > > On 18 Aug 2015 16:21, Joseph Myers wrote:
> > > > This patch, relative to a tree with
> > > > <https://sourceware.org/ml/libc-alpha/2015-08/msg00680.html> and
> > > > <https://sourceware.org/ml/libc-alpha/2015-08/msg00681.html> (pending
> > > > review) applied, removes the use of -Wno-error=undef, so that -Wundef
> > > > warnings become errors.
> > >
> > > lgtm
> > Are you saying those patches look good as well as the -Wno-error=undef
> > removal?
> sure, both lgtm too
Thanks, I've committed those two patches. I'll plan to commit the
-Wno-error=undef removal on Thursday UK time in case anyone wishes to make
last-minute fixes for configurations other than the (x86_64, x86, mips64
three ABIs, arm) ones I've tested.
> > "make check" should do that by default when building with a cross compiler
> > (it will also do tests that only require the build system and not the host
> > glibc runs on, such as the ABI tests).
> hmm, it seems to try to execute for me. probably because cross_compiling=maybe
> rather than yes or no.
It looks like giving both --build and --host explicitly (with the values
being different) should ensure cross_compiling=yes and so disable test
execution. But you can also specify run-built-tests=no explicitly on the
make check command line.
Joseph S. Myers