This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86: sysconf: use new cpuid.h header
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 11 Aug 2015 05:50:50 -0700
- Subject: Re: [PATCH] x86: sysconf: use new cpuid.h header
- Authentication-results: sourceware.org; auth=none
- References: <1439285273-21961-1-git-send-email-vapier at gentoo dot org> <CAMe9rOo=KLGbxWQkof9hSopYEXvkVWr9e8AJ-wpDs8hHVCKAHw at mail dot gmail dot com>
On Tue, Aug 11, 2015 at 3:45 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Aug 11, 2015 at 2:27 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>> This produces better code in the non-PIC case, and when using newer gcc
>> versions (as you can declare ebx as clobbered). Since we require 4.6+,
>> and the nptl code already leverages cpuid.h, using it here should be OK.
>>
>> 2015-08-11 Mike Frysinger <vapier@gentoo.org>
>>
>> * sysdeps/unix/sysv/linux/i386/sysconf.c: Include cpuid.h.
>> (intel_check_word): Change inline cpuid asm to __cpuid_count and
>> __cpuid.
>> (handle_intel, handle_amd, __sysconf): Likewise.
>
> Please fix it on hjl/cpuid/master branch, which I am planning to check in
> shortly.
I removed sysdeps/unix/sysv/linux/i386/sysconf.c on hjl/cpuid/master branch.
Please check it out.
--
H.J.