This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Readd O_LARGEFILE flag for openat64
- From: Andreas Schwab <schwab at suse dot de>
- To: libc-alpha at sourceware dot org
- Date: Mon, 10 Aug 2015 17:47:44 +0200
- Subject: Re: [PATCH] Readd O_LARGEFILE flag for openat64
- Authentication-results: sourceware.org; auth=none
- References: <mvmegjbmh5i dot fsf at hawking dot suse dot de> <20150810151333 dot GN23550 at vapier>
Mike Frysinger <vapier@gentoo.org> writes:
> On 10 Aug 2015 15:01, Andreas Schwab wrote:
>> + error (0, 0, "openat64 is not supported");
>
> shouldn't all of these error() calls be printf ?
Yes, that would be a nice follow-up task to go through all tests.
> maybe test-skeleton.c should close stderr and dupe stdout to it ?
Or this.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."