This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ 13690] Do not violate mutex destruction requirements.
- From: Andreas Schwab <schwab at suse dot de>
- To: David Miller <davem at davemloft dot net>
- Cc: triegel at redhat dot com, libc-alpha at sourceware dot org, carlos at redhat dot com
- Date: Thu, 16 Jul 2015 16:09:53 +0200
- Subject: Re: [PATCH][BZ 13690] Do not violate mutex destruction requirements.
- Authentication-results: sourceware.org; auth=none
- References: <1436905273 dot 19451 dot 14 dot camel at localhost dot localdomain> <20150715 dot 160555 dot 934366773890383260 dot davem at davemloft dot net>
David Miller <davem@davemloft.net> writes:
> From: Torvald Riegel <triegel@redhat.com>
> Date: Tue, 14 Jul 2015 22:21:13 +0200
>
>> Dave, could you test on sparc, please?
>
> This breaks the sparc build:
>
> gconv_db.c: In function â__gconv_find_transformâ:
> gconv_db.c:734:7: error: unused variable â__privateâ [-Werror=unused-variable]
> gconv_db.c:741:7: error: unused variable â__privateâ [-Werror=unused-variable]
> gconv_db.c:760:7: error: unused variable â__privateâ [-Werror=unused-variable]
> gconv_db.c:768:3: error: unused variable â__privateâ [-Werror=unused-variable]
> gconv_db.c: In function â__gconv_close_transformâ:
> gconv_db.c:802:3: error: unused variable â__privateâ [-Werror=unused-variable]
> cc1: all warnings being treated as errors
> make[2]: *** [/home/davem/src/GIT/GLIBC/build-sparcv9/iconv/gconv_db.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> gconv_db.c: In function â__gconv_find_transformâ:
> gconv_db.c:734:7: error: unused variable â__privateâ [-Werror=unused-variable]
> gconv_db.c:741:7: error: unused variable â__privateâ [-Werror=unused-variable]
> gconv_db.c:760:7: error: unused variable â__privateâ [-Werror=unused-variable]
> gconv_db.c:768:3: error: unused variable â__privateâ [-Werror=unused-variable]
> gconv_db.c: In function â__gconv_close_transformâ:
> gconv_db.c:802:3: error: unused variable â__privateâ [-Werror=unused-variable]
> cc1: all warnings being treated as errors
#if IS_IN (libc) || IS_IN (rtld)
/* In libc.so or ld.so all futexes are private. */
^^^^^^^^^^^^^^^^^^^^^^^
# ifdef __ASSUME_PRIVATE_FUTEX
# define __lll_private_flag(fl, private) \
((fl) | FUTEX_PRIVATE_FLAG)
# else
# define __lll_private_flag(fl, private) \
((fl) | THREAD_GETMEM (THREAD_SELF, header.private_futex))
# endif
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."