This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ 13690] Do not violate mutex destruction requirements.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Torvald Riegel <triegel at redhat dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>, "Carlos O'Donell" <carlos at redhat dot com>, David Miller <davem at davemloft dot net>
- Date: Tue, 14 Jul 2015 13:39:27 -0700 (PDT)
- Subject: Re: [PATCH][BZ 13690] Do not violate mutex destruction requirements.
- Authentication-results: sourceware.org; auth=none
- References: <1436905273 dot 19451 dot 14 dot camel at localhost dot localdomain>
> Not tested. Could someone test this on a non-x86-linux machine (I don't
> have one handy). Dave, could you test on sparc, please?
You should always at least build-test your changes.
> #define __lll_unlock(futex, private) \
> ((void) \
> ({ \
> int *__futex = (futex); \
> + int *__private = (private); \
Should be int, not int *.
> #define __lll_robust_unlock(futex, private) \
> ((void) \
> ({ \
> int *__futex = (futex); \
> + int *__private = (private); \
Same here.