This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][AArch64] change greg_t definition in ucontext.h


On 29 May 2015 at 14:55, Carlos O'Donell <carlos@redhat.com> wrote:
> On 05/28/2015 09:37 AM, Szabolcs Nagy wrote:
>> it seems to be used in a few places (gdb, qemu,..)
>> but always under a target specific ifdef to access
>> greg_t members in mcontext.
>
> Is it used for AArch64 though? As far as I can tell gdb
> for AArch64 does not use greg_t.
>
> Either way, the present definition is broken, so the user
> could not have expected it to work in any way, but if the
> type was embedded into a structure and unused, then you
> might have an ABI breaking situation. I do not think you
> are in that case because mcontext on AArch64 doesn't use
> greg_t.

Hi.  The analysis Carlos provided looks sensible to me, go ahead and
commit your patch.
/Marcus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]