This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv2] Update the localedata/locales/translit_* files to Unicode 7.0.0


Hi Mike,

I reviewed the resulting transliteration and special decompose rules and
in general everything looks very good, few minor comments below.

On 2015-06-15 19:04, Mike FABIAN wrote:
> 
> Subject: [PATCH 1/4] Remove duplicate transliterations for U+0152 and U+0153
>  from C-translit.h.in

this looks like an obvious fix.

> Subject: [PATCH 2/4] Addition and fixes for translit_neutral
> 
> +% LATIN CAPITAL LETTER ENG
> +<U014A> <U004E>
> +% LATIN SMALL LETTER ENG
> +<U014B> <U006E>

Hmm, I presume NG/ng would be more expected than N/n here, but reading
https://en.wikipedia.org/wiki/Eng_%28letter%29 doesn't give a clear
answer either way, what do you think?

> +% EURO-CURRENCY SIGN
> +% CRUZEIRO SIGN
> +% FRENCH FRANC SIGN
> +% LIRA SIGN
> +% PESETA SIGN
>  % DONG SIGN
> +% INDIAN RUPEE SIGN
> +% TURKISH LIRA SIGN

While at it, should we perhaps also add pound, ruble, drachma, won, and
hryvnia signs here?

> Subject: [PATCH 3/4] Update the translit files to Unicode 7.0.0

The generated files included in this patch look good.

> Subject: [PATCH 4/4] Add transliteration rules for da, nb, nn, and sv locales.

AFAICS these also look good.

Thanks,

-- 
Marko Myllynen


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]