This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] detect overridden install prefix [BZ #18512]
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Martin Sebor <msebor at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 11 Jun 2015 21:56:24 -0400
- Subject: Re: [PATCH] detect overridden install prefix [BZ #18512]
- Authentication-results: sourceware.org; auth=none
- References: <557A1DCF dot 6080208 at redhat dot com>
On 06/11/2015 07:46 PM, Martin Sebor wrote:
> Attempting to install glibc configured with --prefix=/usr into
> a non-standard directory specified by the prefix make variable
> fails with an error. Carlos indicated this is an unsupported
> use case that he would prefer to detect and error out on early
> in the installation process.
>
> Attached is a simple patch that implements this detection. The
> patch also updates the INSTALL file to mention this caveat and
> recommend using DESTDIR instead. To keep the patch simple
> I didn't implement the idea of detecting whether the overridden
> prefix is actually different than the prefix the library was
> configured with.
>
> ChangeLog:
>
> 2015-06-11 Martin Sebor <msebor@redhat.com>
>
> [BZ #18512]
> * Makerules (check-install-supported): New target.
> install: Add check-install-supported as a dependency.
> * INSTALL (Installing the C Library): Document that overriding
> prefix and exec_prefix is not supported. Mention DESTDIR.
The Makerules changes look good to me.
As Joseph notes INSTALL is a generated file.
OK to commit if you fix the INSTALL bit.
Cheers,
Carlos.