This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix open_memstream namespace (bug 18498)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 8 Jun 2015 10:30:03 +0000
- Subject: Re: Fix open_memstream namespace (bug 18498)
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1506052230060 dot 16975 at digraph dot polyomino dot org dot uk> <20150605223747 dot E39E42C39E3 at topped-with-meat dot com> <alpine dot DEB dot 2 dot 10 dot 1506052254490 dot 16975 at digraph dot polyomino dot org dot uk> <20150606184405 dot 1F2CA2C39DC at topped-with-meat dot com> <20150606184700 dot 4A3932C39DC at topped-with-meat dot com>
On Sat, 6 Jun 2015, Roland McGrath wrote:
> > > The C++ code is in testcases, which produce an "expected initializer
> > > before 'throw'" error if you use the typeof construct (that is, C++ throw
> > > () only works with an actual function declarator, not when typeof is used
> > > to give something a function type). Hence the comment, to explain why
> > > __typeof isn't used.
> >
> > OK. It would not have looked so odd to me if the comment said "C++ tests".
> > Perhaps also some sort of XXX/TODO comment about how this should go away
> > when we one day stop building tests with the internal headers.
>
> Or the decl could just use typeof and be under #ifdef _LIBC, no?
I've made the comment say "C++ tests". This matches what we do in
wchar.h. As far as I know we still define _LIBC when building tests, as
well as using internal headers for them.
--
Joseph S. Myers
joseph@codesourcery.com