This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/14] [x86_64] Vector math functions (vector cos)
- From: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 4 Jun 2015 20:22:47 +0300
- Subject: Re: [PATCH 1/14] [x86_64] Vector math functions (vector cos)
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3t+v7zYEmvWQxV9aRmJB6Ag2hQgQ56cZJTDy=siRBszDw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1504301541120 dot 23221 at digraph dot polyomino dot org dot uk> <CAMXFM3sVJ6vkEF7RqrrHczJSdF_-gr9Xog-zFcG3rjhOqgqjDw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505151616460 dot 21212 at digraph dot polyomino dot org dot uk> <CAMXFM3tfZKDJtjhJ1d=LQ=WALJBBx5ABJXoS5ycBORii78FkEg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505181711240 dot 20209 at digraph dot polyomino dot org dot uk> <CAMXFM3vG=5KVLuG4HJ6StDp13YcpeRLqPkd=3BJhGt1mu5AWPA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505201529070 dot 23246 at digraph dot polyomino dot org dot uk> <CAMXFM3u57e==ySd8TF7+qFwmrswcT1jqzcN-n_JDPF45+77Z0g at mail dot gmail dot com> <CAMXFM3uuDy3f2hb3Xg+MNmseqjmBFqUF1euRF_g5XW+wo7JSSQ at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1505221523570 dot 16611 at digraph dot polyomino dot org dot uk> <CAMXFM3sXNLR3_HPpkUBp_9Ue=-RYZYoidbCwP23Cp9HX_X+t5A at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1506041649010 dot 12011 at digraph dot polyomino dot org dot uk>
2015-06-04 19:50 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
> On Mon, 25 May 2015, Andrew Senkevich wrote:
>
>> > As far as I can tell, if you use --disable-multi-arch, then these files
>> > won't be built into libmvec, and nothing else will provide the
>> > _ZGVbN2v_cos and _ZGVeN8v_cos symbols. See other multiarch code for
>> > examples of how such things are handled - typically, the file outside the
>> > multiarch directory implements things for an always-supported architecture
>> > variant (in this case, that would be a variant guaranteed to be supported
>> > if the given entry point gets called), then, in the multiarch directory,
>> > there are the implementations for other variants, and a file with the same
>> > name as that outside the multiarch directory, that (a) provides the IFUNC
>> > resolver and (b) defines some macros before #including the file in the
>> > directory above, so that the basic version of the function gets defined
>> > under a different name.
>>
>> Hi, Joseph, updated patch is attached. Is it ok?
>
> OK provided you've tested this both with and without --disable-multi-arch.
Thank you for review, of course both cases were tested.
--
WBR,
Andrew