This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PR18457] Don't require rtld lock to compute DTV addr for static TLS
- From: Torvald Riegel <triegel at redhat dot com>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: Andreas Schwab <schwab at linux-m68k dot org>, libc-alpha at sourceware dot org
- Date: Thu, 04 Jun 2015 14:30:42 +0200
- Subject: Re: [PR18457] Don't require rtld lock to compute DTV addr for static TLS
- Authentication-results: sourceware.org; auth=none
- References: <orvbf5ffyt dot fsf at livre dot home> <1433326788 dot 21461 dot 81 dot camel at triegel dot csb> <ora8whexn9 dot fsf at livre dot home> <1433344426 dot 21461 dot 202 dot camel at triegel dot csb> <orwpzkee1h dot fsf at livre dot home> <orr3psedpw dot fsf at livre dot home>
On Wed, 2015-06-03 at 17:31 -0300, Alexandre Oliva wrote:
> On Jun 3, 2015, Alexandre Oliva <aoliva@redhat.com> wrote:
>
> > How's this?
>
> Or rather this, that I got after updating the patch file :-)
Why did you remove the atomic accesses altogether? I argued that we
need *more*, not less. You can't just pretend those issues don't exist.
You made good progress towards a consistent fix with the reasoning on
synchronization you provided for the static case, and the information
you provided for the non-static case.
This doesn't add any of the documentation I want to see either. Not OK.
> (the testcase is adjusted to use atomics)
Test case is OK. Thanks.