This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix fnmatch strnlen namespace (bug 18470)
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 3 Jun 2015 00:51:25 +0200
- Subject: Re: Fix fnmatch strnlen namespace (bug 18470)
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1506022135310 dot 2704 at digraph dot polyomino dot org dot uk>
On Tue, Jun 02, 2015 at 09:35:47PM +0000, Joseph Myers wrote:
> fnmatch brings in references to strnlen, which isn't in all the
> standards that contain fnmatch (not added until the 2008 edition of
> POSIX), resulting in linknamespace test failures. (This is contrary
> to glibc conventions, rather than a standards conformance issue,
> because of the str* reservation.) This patch fixes this in the usual
> way, using __strnlen instead of strnlen.
>
> Tested for x86_64 and x86 (testsuite, and that installed stripped
> shared libraries are unchanged by the patch). The testing is on top
> of <https://sourceware.org/ml/libc-alpha/2015-06/msg00019.html>
> (pending review); the dependence is that both patches are needed for
> most of the removals of XFAILs, rather than any other interaction
> between the patches.
>
looks ok.