This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove __isinf uses that rely on signed return value
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Wilco Dijkstra <wdijkstr at arm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 2 Jun 2015 17:42:57 +0000
- Subject: Re: [PATCH] Remove __isinf uses that rely on signed return value
- Authentication-results: sourceware.org; auth=none
- References: <001301d09d57$c0bfdf60$423f9e20$ at com>
On Tue, 2 Jun 2015, Wilco Dijkstra wrote:
> The printf code contains a few uses of __isinf where the sign is used -
> replace these with separate isinf and signbit.
Why? Isn't the point of glibc's isinf returning a signed value that you
can do such combined operations?
I'd also really recommend separating safe cleanups that don't change the
stripped installed shared libraries at all (other than assertion line
numbers), such as moving to use the type-generic macros internally, from
any other changes that might affect the installed binaries. And when
something shouldn't change the (stripped) installed binaries, verify that
it doesn't, and state the platform on which you did such verification.
--
Joseph S. Myers
joseph@codesourcery.com