This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use inline syscalls for non-cancellable versions
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, GNU C Library <libc-alpha at sourceware dot org>, Chris Metcalf <cmetcalf at tilera dot com>
- Date: Sat, 23 May 2015 22:21:46 -0400
- Subject: Re: [PATCH] Use inline syscalls for non-cancellable versions
- Authentication-results: sourceware.org; auth=none
- References: <555C97F7 dot 1060700 at linaro dot org> <555E4B67 dot 6000104 at linaro dot org>
On 05/21/2015 05:17 PM, Adhemerval Zanella wrote:
> On issue I found for this patchset is it fails for tile (and it is the
> only architecture I found that this warning shows) with:
>
> --
>
> malloc.c: In function â_int_freeâ:
> ../sysdeps/unix/sysv/linux/malloc-sysdep.h:51:35: error: âvalâ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> may_shrink_heap = n > 0 && val == '2';
> ^
> ../sysdeps/unix/sysv/linux/malloc-sysdep.h:49:9: note: âvalâ was declared here
> char val;
>
> --
>
> It is due the fact 'read_not_cancel' now calls the INLINE_SYSCALL for the
> architecture and so 'tile' version is triggering this issue for some reason
> (I did not check exactly why, any tile expert could help me out here?).
>
> The straightforward fix would just initialize this variable, but this is
> just clobbering tile potential issue. Any recommendations?
Ask Chris Metcalf for help? :-)
Cheers,
Carlos.