This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ 18234] struct stat is not posix conform
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Carlos O'Donell <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>
- Date: Fri, 22 May 2015 10:24:33 +0100
- Subject: Re: [PATCH][BZ 18234] struct stat is not posix conform
- Authentication-results: sourceware.org; auth=none
- References: <555CA657 dot 2050300 at arm dot com> <555CB539 dot 4090208 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1505201627430 dot 23246 at digraph dot polyomino dot org dot uk> <555CCA76 dot 2010605 at arm dot com> <20150521042934 dot GM15498 at spoyarek dot pnq dot redhat dot com> <555E04B0 dot 1020801 at arm dot com> <20150521162331 dot GY15498 at spoyarek dot pnq dot redhat dot com>
On 21/05/15 17:23, Siddhesh Poyarekar wrote:
> On Thu, May 21, 2015 at 05:15:44PM +0100, Szabolcs Nagy wrote:
>> here is the patch with consistent __USE_XOPEN2K8
>>
>> ok to commit?
>>
>> 2015-05-21 Szabolcs Nagy <szabolcs.nagy@arm.com>
>>
>> [BZ #18234]
>> * conform/data/sys/stat.h-data (struct stat): Add tests for st_atim,
>> st_mtim and st_ctim members.
>>
>> * sysdeps/nacl/bits/stat.h (struct stat, struct stat64): Make
>> st_atim, st_ctim, st_mtim visible under __USE_XOPEN2K8 only.
>>
>> * sysdeps/unix/sysv/linux/generic/bits/stat.h (struct stat,):
>> (struct stat64): Likewise.
>>
>> * sysdeps/unix/sysv/linux/ia64/bits/stat.h (struct stat,):
>> (struct stat64): Likewise.
>>
>> * sysdeps/unix/sysv/linux/microblaze/bits/stat.h (struct stat,):
>> (struct stat64): Likewise.
>
> The Changelog entry lines should not have the extra newlines. Looks
> fine to me other than that. It doesn't look like you have commit
> access, so I'll commit it tomorrow for you.
>
thanks, that would be nice.
changelog, without empty lines:
2015-05-22 Szabolcs Nagy <szabolcs.nagy@arm.com>
[BZ #18234]
* conform/data/sys/stat.h-data (struct stat): Add tests for st_atim,
st_mtim and st_ctim members.
* sysdeps/nacl/bits/stat.h (struct stat, struct stat64): Make
st_atim, st_ctim, st_mtim visible under __USE_XOPEN2K8 only.
* sysdeps/unix/sysv/linux/generic/bits/stat.h (struct stat,):
(struct stat64): Likewise.
* sysdeps/unix/sysv/linux/ia64/bits/stat.h (struct stat,):
(struct stat64): Likewise.
* sysdeps/unix/sysv/linux/microblaze/bits/stat.h (struct stat,):
(struct stat64): Likewise.