This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ 14172] Add South Azerbaijani (azb) locale
- From: Marko Myllynen <myllynen at redhat dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>, Mjbmr <mjbmri at gmail dot com>, libc-alpha at sourceware dot org
- Date: Mon, 11 May 2015 14:18:03 +0300
- Subject: Re: [PATCH][BZ 14172] Add South Azerbaijani (azb) locale
- Authentication-results: sourceware.org; auth=none
- References: <554AF03A dot 2010601 at gmail dot com> <554B2148 dot 3090707 at redhat dot com> <554BF472 dot 8050703 at gmail dot com> <554BFC89 dot 1060003 at gmail dot com> <554C78C5 dot 2060708 at redhat dot com> <554CD3B4 dot 9050304 at redhat dot com>
- Reply-to: myllynen at redhat dot com
Hi Carlos,
On 2015-05-08 18:18, Carlos O'Donell wrote:
> On 05/08/2015 04:50 AM, Marko Myllynen wrote:
>>
>> looks pretty good to me. Again, I can't comment on the language itself
>> but if it now compiles then at least the basics should be ok.
>
> How do we want to handle this patch? Should we just check in as a new
> supported localization? I feel like the answer should be "Yes." Then
> the downstream distributions can enable it if they see fit, and we can
> start getting feedback from real azb users about the quality of the
> locale itself.
yes, agreed.
> Thoughts? Do you have commit privileges to check this in? Do you want
> them? It would require at least doing a quick glibc build to validate
> the locale works before committing :-)
Could you please commit it (I don't have privileges)?
I did a quick glibc build and it was a worthwhile effort - the locale
itself is now ok but I needed to adjust the Locales wiki page a bit for
cases where a new language code is used and also noticed that when doing
"make localedata/install-locales install_root=..." it doesn't halt on
errors, that's probably why we have bo_CN and bo_IN in the tree which
don't compile. Not sure is not halting on errors wanted or not but below
is a quick&dirty patch to fix the compilation issues.
2015-05-11 Marko Myllynen <myllynen@redhat.com>
* locales/bo_CN (LC_NAME): Fix compilation.
* locales/bo_IN (LC_NAME): Likewise.
---
localedata/locales/bo_CN | 2 +-
localedata/locales/bo_IN | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/localedata/locales/bo_CN b/localedata/locales/bo_CN
index d813c10..8c866ab 100644
--- a/localedata/locales/bo_CN
+++ b/localedata/locales/bo_CN
@@ -146,7 +146,7 @@ END LC_MEASUREMENT
LC_NAME
% FIXME
-name_fmt ""
+name_fmt " "
% name_gen "FIXME"
% name_miss "FIXME"
% name_mr "FIXME"
diff --git a/localedata/locales/bo_IN b/localedata/locales/bo_IN
index 8ab793c..b396ee1 100644
--- a/localedata/locales/bo_IN
+++ b/localedata/locales/bo_IN
@@ -71,7 +71,7 @@ END LC_MEASUREMENT
LC_NAME
% FIXME
-name_fmt ""
+name_fmt " "
% name_gen "FIXME"
% name_miss "FIXME"
% name_mr "FIXME"
--
2.4.0
Thanks,
--
Marko Myllynen