This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [COMMITTED PATCH] BZ#18383: Add test case for large alignment in TLS blocks.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Thu, 7 May 2015 14:10:00 -0700 (PDT)
- Subject: Re: [COMMITTED PATCH] BZ#18383: Add test case for large alignment in TLS blocks.
- Authentication-results: sourceware.org; auth=none
- References: <20150506203535 dot 48EAF2C3B9D at topped-with-meat dot com> <CAMe9rOqryFresZrjXDwTnNBVseWh6YfgMAN5+niO4oJhA2-RoA at mail dot gmail dot com> <20150507201552 dot BD89F2C3BA8 at topped-with-meat dot com> <CAMe9rOr4kRxVYXnrxhAm7ctkxMEJtbMx3Qwhza6LUyYj03yjZw at mail dot gmail dot com>
The log entry needs the BZ# marker.
I'm having a hard time finding the calculation in the dynamic-linking case
that corresponds to this piece of __libc_setup_tls. Since there are two
places where the logic should match, we really should make it much more
clear how they relate. If there isn't any obvious refactoring that would
share more of this logic between the two cases, can you at least add a
comment in __libc_setup_tls that points to the implementation of the
matching logic in the dynamic-linking case?
Thanks,
Roland