This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: -Winline option

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: David Miller <davem at davemloft dot net>, roland at hack dot frob dot com
Cc: fweimer at redhat dot com, libc-alpha at sourceware dot org
Date: Thu, 09 Apr 2015 23:56:56 -0700
Subject: Re: -Winline option
Authentication-results: sourceware.org; auth=none
References: <55269642 dot 8040507 at redhat dot com> <20150409 dot 141202 dot 1584701513523037804 dot davem at davemloft dot net> <20150409192408 dot 6BB132C3B96 at topped-with-meat dot com> <20150409 dot 171238 dot 122593176026308256 dot davem at davemloft dot net>

David Miller wrote:

In this particular case the inline is in a header file to provide a
function used by applications.

As I understand it <scratch_buffer.h> is a private header, not for use byapplications. See, e.g.,<https://sourceware.org/ml/libc-alpha/2015-04/msg00047.html> where I ask "Thesefunctions are all private to glibc, right?" and the followup<https://sourceware.org/ml/libc-alpha/2015-04/msg00067.html> where Florian says"My concern was the internal ABI between libc and the NSS modules."

If <scratch_buffer.h> is intended to be public then we have a problem, as C99frowns on public headers defining static inline functions for use in applicationcode.

Follow-Ups:
- Re: -Winline option
  - From: Florian Weimer

References:
- -Winline option (was: Re: [PATCH 06/25] Add struct scratch_buffer and its internal helper functions)
  - From: Florian Weimer
- Re: -Winline option
  - From: David Miller
- Re: -Winline option
  - From: Roland McGrath
- Re: -Winline option
  - From: David Miller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]