This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] in6_addr: add 64-bit union accessors
- From: Rich Felker <dalias at libc dot org>
- To: Shawn Landden <shawn at churchofgit dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 30 Mar 2015 02:34:34 -0400
- Subject: Re: [PATCH] in6_addr: add 64-bit union accessors
- Authentication-results: sourceware.org; auth=none
- References: <1427670922-3534376-1-git-send-email-shawn at churchofgit dot com>
On Sun, Mar 29, 2015 at 04:15:22PM -0700, Shawn Landden wrote:
> 64-bit architectures are common so this makes sense to have.
> 64-bit arches were not so common 1997-02-16.
>
> I'm not going to change the ChangeLog because that practice
> breaks git merges.
>
> Bugzilla: #18117
> Signed-off-by: Shawn Landden <shawn@churchofgit.com>
> ---
> inet/netinet/in.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/inet/netinet/in.h b/inet/netinet/in.h
> index f541c58..b64b559 100644
> --- a/inet/netinet/in.h
> +++ b/inet/netinet/in.h
> @@ -214,12 +214,14 @@ struct in6_addr
> #ifdef __USE_MISC
> uint16_t __u6_addr16[8];
> uint32_t __u6_addr32[4];
> + uint64_t __u6_addr64[2];
> #endif
This breaks ABI by changing the alignment requirement from 4 to 8. I
think that's a show-stopper for this proposal.
Rich