This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] sha2: new header <sha2.h>
- From: Allan McRae <allan at archlinux dot org>
- To: Shawn Landden <shawn at churchofgit dot com>, libc-alpha at sourceware dot org
- Date: Sat, 28 Mar 2015 15:52:56 +1000
- Subject: Re: [PATCH] sha2: new header <sha2.h>
- Authentication-results: sourceware.org; auth=none
- References: <CAJusiZVeSiuBJ1NuWw9KU2fboKcz6-9s6YhiTHVga5GyW-bbFw at mail dot gmail dot com> <1427492368-3482458-1-git-send-email-shawn at churchofgit dot com> <20150328034628 dot GC27135 at vapier>
On 28/03/15 13:46, Mike Frysinger wrote:
> On 27 Mar 2015 14:39, Shawn Landden wrote:
>> --- a/configure.ac
>> +++ b/configure.ac
>> - nss_includes=-I$(nss-config --includedir 2>/dev/null)
>> + nss_includes=$(pkg-config --cflags-only-I nss)
> you cannot hardcode `pkg-config`. you must respect $PKG_CONFIG. normally
> you'd use PKG_PROG_PKG_CONFIG, but that'd require an external pkg.m4 to be
> available, so do this instead earlier in the file:
> AC_PATH_TOOL([PKG_CONFIG], [pkg-config])
Doesn't that add a build dependency that is currently not required?
What is the advantage of this change?
Also, it would be very helpful if a list of changes was given for each
new revision of a patch. Also add a revision number so that we know
that latest version (git format-patch --reroll-count=?). There were
four revisions posted while I slept last night...
Finally, I did not see a direct answer to Roland's query about
justifying the change. Well, one version of the patch got a commit
message - it would have been better to reply directly to that email and
establish that this change is indeed wanted.