This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [BZ#17090/17620/17621]: fix DTV race, assert, and DTV_SURPLUS Static TLS limit

On 03/05/2015 05:42 PM, Alexandre Oliva wrote:
> On Mar  5, 2015, Alexandre Oliva <> wrote:
>> > On Mar  4, 2015, Alan Modra <> wrote:
>>> >> On Wed, Mar 04, 2015 at 03:35:29PM +1030, Alan Modra wrote:
>>>> >>> As does nptl/tst-stack4 on x86_64 if is built with
>>>> >>> -mtls-dialect=gnu2.
>>> >> This on top of your patch gets me past the segfault in free().
>>> >> I now hit another segfault, tst-stack4mod.c:function somehow has
>>> >> var == NULL.
>> > Thanks, here's an incremental patch that fixes the attempt to release
>> > the pointer from an entry past the end of the dtv (that you fixed
>> > above); that ensures we don't use, in a TLS Descriptor, the generation
>> > count of an earlier map that used the same dtv slot (this ensures we
>> > update the DTV instead of happily using a NULL pointer in there); and
>> > that silences a -Wundef warning in nptl_db, that I had missed when I
>> > updated the #ifs for the last-posted version of the patch.
>> > I'm now running a full build and test cycle with the combined patch,
>> > that I will post once it (hopefully ;-) completes successfully.
> Success (x86_64-linux-gnu, with -mtls-dialect=gnu2)!

The patch looks good to me.  (And success with aarch64-linux-gnu!)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]