This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Error on setenv(..., NULL, ...)

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>, Paul Pluzhnikov <ppluzhnikov at google dot com>, GLIBC Devel <libc-alpha at sourceware dot org>
Date: Wed, 11 Mar 2015 23:02:27 +0530
Subject: Re: [patch] Error on setenv(..., NULL, ...)
Authentication-results: sourceware.org; auth=none
References: <CALoOobNSbWUkd_i-L6U0ovbqPYnJY-h=ftX1K61yb19pmJj6aw at mail dot gmail dot com> <20150311163327 dot GV9714 at spoyarek dot pnq dot redhat dot com> <55006F71 dot 6000807 at arm dot com> <20150311164415 dot GW9714 at spoyarek dot pnq dot redhat dot com> <20150311172546 dot GA877 at vapier>

On Wed, Mar 11, 2015 at 01:25:46PM -0400, Mike Frysinger wrote:
> if we agree it's undefined behavior, then can't we have fortification turn this 
> into a build failure ?

The compiler already warns about the non-null requirement where it can
find it, so making it fail shouldn't be hard.  Maybe we could add the
assert as Joseph suggests for FORTIFY_SOURCE.  I am not convinced that
it would be conservative enough to do fail catastrophically in the
default case, hence my suggestion to return a blank string instead of
the bad value.

Siddhesh

Attachment: pgprloi3mGAR8.pgp
Description: PGP signature

References:
- [patch] Error on setenv(..., NULL, ...)
  - From: Paul Pluzhnikov
- Re: [patch] Error on setenv(..., NULL, ...)
  - From: Siddhesh Poyarekar
- Re: [patch] Error on setenv(..., NULL, ...)
  - From: Szabolcs Nagy
- Re: [patch] Error on setenv(..., NULL, ...)
  - From: Siddhesh Poyarekar
- Re: [patch] Error on setenv(..., NULL, ...)
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]