This is the mail archive of the
mailing list for the glibc project.
Re: [COMMITTED PATCH] Avoid C++ tests when the C++ cannot be linked.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Sat, 07 Mar 2015 13:37:00 -0500
- Subject: Re: [COMMITTED PATCH] Avoid C++ tests when the C++ cannot be linked.
- Authentication-results: sourceware.org; auth=none
- References: <20150304215551 dot 7E6E22C3B7B at topped-with-meat dot com> <54F8BB28 dot 90804 at redhat dot com> <20150307003747 dot D5EBF2C3B39 at topped-with-meat dot com>
On 03/06/2015 07:37 PM, Roland McGrath wrote:
>> I don't like this. The semantics I would rather have are that all such
>> tests fail, not fail to build, but fail. Then the results of `make check`
>> represent reality with all the C++ tests failing because you don't have
>> a libstdc++. This way it's clear that you haven't passed all of the testing
>> for glibc.
> I don't like the conflation of unbuildable with failed. What we need is
> the possibility of UNSUPPORTED as an outcome for our tests. I'll send a
> change in that direction.
Good point. I like UNSUPPORTED better. My worry is that these tests simply
go missing and we don't notice. Fail safe is better.