This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Replace __attribute__((visibility("protected")))
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 6 Mar 2015 14:59:04 -0800 (PST)
- Subject: Re: [PATCH] Replace __attribute__((visibility("protected")))
- Authentication-results: sourceware.org; auth=none
- References: <20150306194153 dot GA30470 at intel dot com> <20150306222846 dot 6D37E2C3B39 at topped-with-meat dot com> <CAMe9rOpiGcP+mQdh9d2B6WpCMZq4X8dQhkRPc6oGRFAd_r2zXA at mail dot gmail dot com>
> On Fri, Mar 6, 2015 at 2:28 PM, Roland McGrath <roland@hack.frob.com> wrote:
> > It needs comments.
>
> Did you mean duplicate my commit log to each
> __attribute__ ((visibility ("protected"))) change?
> What about existing
>
> asm (".protected xxx");
>
> Do they also need comments? I don't think it is necessary
> since the commit log explains why a change is made.
What's necessary is that comments next to the actual code explain why it's
any nonobvious way it is. In this case, you need a short comment
mentioning the GCC bug in each place that you're avoiding using the obvious
compiler feature because of a bug.