This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Replace __attribute__((visibility("protected")))


On 06 Mar 2015 13:11, H.J. Lu wrote:
> On Fri, Mar 6, 2015 at 12:11 PM, Andreas Schwab wrote:
> > "H.J. Lu" <hongjiu.lu@intel.com> writes:
> >
> >> diff --git a/elf/ifuncdep2.c b/elf/ifuncdep2.c
> >> index 99d1926..599eba7 100644
> >> --- a/elf/ifuncdep2.c
> >> +++ b/elf/ifuncdep2.c
> >> @@ -2,7 +2,8 @@
> >>
> >>  #include "ifunc-sel.h"
> >>
> >> -int global __attribute__ ((visibility ("protected"))) = -1;
> >> +int global = -1;
> >> +asm (".protected global");
> >
> > Some architectures use a symbol prefix.
> 
> Here is the updated patch to use __SYMBOL_PREFIX.  OK
> to install?

a bunch of the elf/ files don't utilize __SYMBOL_PREFIX already.  would be nice 
if we have ASM_SYMBOL_NAME to complement the C_SYMBOL_NAME in libc-symbols.h.  
and maybe a protected_def() macro so you could do:
	protected_def (global);

at any rate, this patch as-is lgtm.
-mike

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]