This is the mail archive of the
mailing list for the glibc project.
Re: Fix sysdeps/unix/sysv/linux/arm/libc-do-syscall.S warning
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org, Mike Frysinger <vapier at gentoo dot org>
- Date: Fri, 06 Mar 2015 10:13:32 -0500
- Subject: Re: Fix sysdeps/unix/sysv/linux/arm/libc-do-syscall.S warning
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1411261513490 dot 27454 at digraph dot polyomino dot org dot uk> <20150302041414 dot GR19363 at vapier> <alpine dot DEB dot 2 dot 10 dot 1503022312530 dot 32749 at digraph dot polyomino dot org dot uk> <54F8AF68 dot 9090803 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1503052213010 dot 31721 at digraph dot polyomino dot org dot uk> <54F8D737 dot 4040003 at redhat dot com> <20150305235128 dot GH19311 at vapier>
On 03/05/2015 06:51 PM, Mike Frysinger wrote:
> Joseph fixed the warning in this one .S file by undefining the symbol.
> since the warning originated in features.h and can be triggered by any
> .S file (in glibc or non-glibc code), i suggested maybe we change the
> features.h header instead so we never have to worry about it again. i
> don't see that as superfluous ... more fixing it in the right place.
I agree. My point is that we should do what's right for glibc first.
If there are two ways to fix this in glibc, and one way involves modifying
any assembly that includes the header, and the other solves the problem
once, then the changes to header are a better solution, for glibc, in my
opinion. This doesn't take into account any user requirements to include
the header in assembly files.
> to the larger question Joseph and you raise, i don't have an answer for
> that. i don't think we've even thought about it beyond specific requests.
Exactly my point, and we shouldn't worry about it until we get such requests.